rahil-c commented on code in PR #13642:
URL: https://github.com/apache/hudi/pull/13642#discussion_r2241057914
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java:
##########
@@ -275,4 +281,98 @@ protected Pair<Map<ConfigProperty, String>,
List<ConfigProperty>> downgrade(Hood
throw new HoodieUpgradeDowngradeException(fromVersion.versionCode(),
toVersion.versionCode(), false);
}
}
+
+ protected UpgradeHandler getUpgradeHandlerInstance(HoodieTableVersion
fromVersion, HoodieTableVersion toVersion) {
+ if (fromVersion == HoodieTableVersion.ZERO && toVersion ==
HoodieTableVersion.ONE) {
+ return new ZeroToOneUpgradeHandler();
Review Comment:
I can try looking into this
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java:
##########
@@ -144,16 +154,12 @@ public void run(HoodieTableVersion toVersion, String
instantTime) {
.run(toVersion, instantTime);
}
} catch (Exception e) {
- LOG.warn("Unable to upgrade or downgrade the metadata table to version
" + toVersion
- + ", ignoring the error and continue.", e);
+ throw new HoodieUpgradeDowngradeException("Upgrade/downgrade for the
Hudi metadata table failed. "
+ + "Please try again. If the failure repeats for metadata table, it
is recommended to delete "
Review Comment:
will fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
