danny0405 commented on code in PR #13632:
URL: https://github.com/apache/hudi/pull/13632#discussion_r2238622005
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/AvroOrcUtils.java:
##########
@@ -496,13 +497,41 @@ public static Object readFromVector(TypeDescription type,
ColumnVector colVector
case SHORT:
return (short) ((LongColumnVector) colVector).vector[vectorPos];
case INT:
- return (int) ((LongColumnVector) colVector).vector[vectorPos];
case LONG:
- return ((LongColumnVector) colVector).vector[vectorPos];
+ long longValue = ((LongColumnVector) colVector).vector[vectorPos];
+ switch (avroSchema.getType()) {
+ case INT:
Review Comment:
why we handle schema evolution here on the reader directly? do we have
similiar stuff for parquet? I see the parquet we have
`HoodieAvroParquetReaderIterator` to handle the schema evolution after the
read, can we follow that? Kind of think the very basic reader should not care
about schema evolution thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
