yihua commented on code in PR #13563:
URL: https://github.com/apache/hudi/pull/13563#discussion_r2237941939


##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieNativeAvroHFileReader.java:
##########
@@ -421,17 +436,19 @@ private static class RecordByKeyIterator implements 
ClosableIterator<IndexedReco
 
     private final Schema readerSchema;
     private final Schema writerSchema;
+    private final Option<BloomFilter> bloomFilterOption;
 
     private IndexedRecord next = null;
 
     RecordByKeyIterator(HFileReader reader, List<String> sortedKeys, Schema 
writerSchema,
-                        Schema readerSchema) throws IOException {
+                        Schema readerSchema, Option<BloomFilter> 
bloomFilterOption) throws IOException {

Review Comment:
   This is a bloom filter object built from the existing keys in the file, so 
it's not a predicate itself.  The predicate is represented by the `sortedKeys`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to