linliu-code commented on code in PR #13517:
URL: https://github.com/apache/hudi/pull/13517#discussion_r2237613216
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -336,4 +350,43 @@ protected static Option<IndexedRecord>
toAvroRecord(HoodieRecord record, Schema
return Option.empty();
}
}
+
+ protected boolean
shouldTrackEventTimeWaterMarkerBasedOnMergeMode(HoodieTableMetaClient
metaClient) {
+ // Only for event time ordering mode.
+ return metaClient.getTableConfig().getRecordMergeMode() ==
RecordMergeMode.EVENT_TIME_ORDERING;
Review Comment:
Ok. But don't forget the readability conveyed from the function name.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -336,4 +350,43 @@ protected static Option<IndexedRecord>
toAvroRecord(HoodieRecord record, Schema
return Option.empty();
}
}
+
+ protected boolean
shouldTrackEventTimeWaterMarkerBasedOnMergeMode(HoodieTableMetaClient
metaClient) {
+ // Only for event time ordering mode.
+ return metaClient.getTableConfig().getRecordMergeMode() ==
RecordMergeMode.EVENT_TIME_ORDERING;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
