nsivabalan commented on code in PR #13519:
URL: https://github.com/apache/hudi/pull/13519#discussion_r2233189382


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeHandler.java:
##########
@@ -36,9 +38,12 @@ public interface UpgradeHandler {
    * @param context                instance of {@link HoodieEngineContext} to 
be used.
    * @param instantTime            current instant time that should not be 
touched.
    * @param upgradeDowngradeHelper instance of {@link 
SupportsUpgradeDowngrade} to be used.
-   * @return Map of config properties and its values to be added to table 
properties.
+   * @return Map of config properties and its values to be added to table 
properties,
+   *         and a list configs to remove.
    */
-  Map<ConfigProperty, String> upgrade(
-      HoodieWriteConfig config, HoodieEngineContext context, String 
instantTime,
+  Pair<Map<ConfigProperty, String>, List<ConfigProperty>> upgrade(

Review Comment:
   sure. fixed it in latest commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to