the-other-tim-brown commented on code in PR #13623:
URL: https://github.com/apache/hudi/pull/13623#discussion_r2231423817
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -413,9 +413,18 @@ public Comparable getOrderingValue(T record,
* @param baseRecord The record based on which the engine record is
built.
* @return A new instance of engine record type {@link T}.
*/
- public abstract T constructEngineRecord(Schema schema,
- Map<Integer, Object> updateValues,
- BufferedRecord<T> baseRecord);
+ public abstract T mergeEngineRecord(Schema schema,
Review Comment:
Can this be `update` instead of `merge`? It is confusing since we use merge
elsewhere to mean taking two records, comparing them, and then outputting a
record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
