lokeshj1703 commented on code in PR #13526:
URL: https://github.com/apache/hudi/pull/13526#discussion_r2230929536
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -1190,8 +1190,12 @@ public TableBuilder setBaseFileFormat(String
baseFileFormat) {
return this;
}
- public TableBuilder setPreCombineField(String preCombineField) {
- this.preCombineField = preCombineField;
+ /**
+ * Sets preCombine fields to be used by the table
Review Comment:
Addressed
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -926,8 +927,12 @@ static RecordMergeMode
inferRecordMergeModeFromMergeStrategyId(String recordMerg
}
}
- public String getPreCombineField() {
- return getString(PRECOMBINE_FIELD);
+ public Option<List<String>> getPreCombineFields() {
Review Comment:
Addressed
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala:
##########
@@ -255,6 +257,16 @@ object HoodieDatasetBulkInsertHelper
}
}
+ private def getOrderingValue(nestedFieldPaths: List[NestedFieldPath], r:
InternalRow): Comparable[_] = {
+ if (nestedFieldPaths.isEmpty) {
+ EmptyOrderingValue.getInstance();
+ } else if (nestedFieldPaths.size == 1) {
+ getNestedInternalRowValue(r,
nestedFieldPaths.head).asInstanceOf[Comparable[_]]
+ } else {
+ new MultipleFieldsOrderingValue(nestedFieldPaths.map(_ =>
getNestedInternalRowValue(r,
nestedFieldPaths.head).asInstanceOf[Comparable[_]]).toArray)
Review Comment:
Addressed
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala:
##########
@@ -255,6 +257,16 @@ object HoodieDatasetBulkInsertHelper
}
}
+ private def getOrderingValue(nestedFieldPaths: List[NestedFieldPath], r:
InternalRow): Comparable[_] = {
+ if (nestedFieldPaths.isEmpty) {
+ EmptyOrderingValue.getInstance();
+ } else if (nestedFieldPaths.size == 1) {
+ getNestedInternalRowValue(r,
nestedFieldPaths.head).asInstanceOf[Comparable[_]]
+ } else {
+ new MultipleFieldsOrderingValue(nestedFieldPaths.map(_ =>
getNestedInternalRowValue(r,
nestedFieldPaths.head).asInstanceOf[Comparable[_]]).toArray)
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
