danny0405 commented on code in PR #13580:
URL: https://github.com/apache/hudi/pull/13580#discussion_r2230076562
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecord.java:
##########
@@ -64,7 +68,8 @@ public static <T> BufferedRecord<T>
forRecordWithContext(HoodieRecord<T> record,
} catch (IOException e) {
throw new HoodieException("Failed to get isDelete from record.", e);
}
- return new BufferedRecord<>(recordKey, record.getOrderingValue(schema,
props), record.getData(), schemaId, isDelete);
+ T row = record.getData();
+ return new BufferedRecord<>(recordKey, readerContext.getOrderingValue(row,
schema, orderingFieldName), row, schemaId, isDelete);
Review Comment:
we should use `readerContext.getOrderingValue(` instead of
`record.getOrderingValue(` to unify the ordering value format in
`BufferedRecord`, `record.getOrderingValue(` is engine agnostic(maybe used in
serialized value such as `DeleteRecord`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
