the-other-tim-brown commented on code in PR #13526: URL: https://github.com/apache/hudi/pull/13526#discussion_r2223719842
########## hudi-common/src/main/java/org/apache/hudi/Comparables.java: ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi; + +import org.apache.hudi.common.util.ValidationUtils; + +import java.io.Serializable; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Objects; +import java.util.function.Function; +import java.util.stream.Collectors; + +import static org.apache.hudi.common.model.HoodieRecord.DEFAULT_ORDERING_VALUE; + +public class Comparables implements Comparable, Serializable { + protected static final long serialVersionUID = 1L; + + private final List<Comparable> comparables; Review Comment: The overhead of a SingletonList is minimal, it is just wrapping a record similar to what we will be doing by introducing any wrapper class. I agree with @danny0405 though that it makes most sense to have some interface and two sub-classes here so the common case of a single ordering field is as straightforward as possible. My preference is also to have the name reflect the use case here instead of being overly general at this point. If we find a second use case, we can update names at that point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
