linliu-code commented on code in PR #13519:
URL: https://github.com/apache/hudi/pull/13519#discussion_r2222695383
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java:
##########
@@ -228,7 +233,9 @@ public void run(HoodieTableVersion toVersion, String
instantTime) {
}
}
- protected Map<ConfigProperty, String> upgrade(HoodieTableVersion
fromVersion, HoodieTableVersion toVersion, String instantTime) {
+ protected Pair<Map<ConfigProperty, String>, List<ConfigProperty>>
upgrade(HoodieTableVersion fromVersion,
+
HoodieTableVersion toVersion,
+
String instantTime) {
Review Comment:
We need to return removed configurations during upgrade. Previously it only
returns the updated configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
