lokeshj1703 commented on code in PR #13526:
URL: https://github.com/apache/hudi/pull/13526#discussion_r2218392949
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -900,8 +900,13 @@ static RecordMergeMode
inferRecordMergeModeFromMergeStrategyId(String recordMerg
}
}
- public String getPreCombineField() {
- return getString(PRECOMBINE_FIELD);
+ public Option<List<String>> getPreCombineFieldList() {
Review Comment:
Addressed
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/catalyst/catalog/HoodieCatalogTable.scala:
##########
@@ -127,9 +128,9 @@ class HoodieCatalogTable(val spark: SparkSession, var
table: CatalogTable) exten
lazy val primaryKeys: Array[String] =
tableConfig.getRecordKeyFields.orElse(Array.empty)
/**
- * PreCombine Field
+ * Comparables Field
*/
- lazy val preCombineKey: Option[String] =
Option(tableConfig.getPreCombineField)
+ lazy val preCombineKey: Option[String] =
convertHudiOptionToScalaOption(tableConfig.getPreCombineFields)
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
