danny0405 commented on code in PR #13580:
URL: https://github.com/apache/hudi/pull/13580#discussion_r2218134214
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -116,16 +117,69 @@ public HoodieFileGroupReader(HoodieReaderContext<T>
readerContext, HoodieStorage
long start, long length, boolean shouldUseRecordPosition) {
this(readerContext, storage, tablePath, latestCommitTime, fileSlice,
dataSchema,
requestedSchema, internalSchemaOpt, hoodieTableMetaClient, props,
start, length,
- shouldUseRecordPosition, false, false, false, Option.empty(), false);
+ shouldUseRecordPosition, false, false, false, Collections.emptyList(),
false);
+ }
+
+ private HoodieFileGroupReader(HoodieReaderContext<T> readerContext,
HoodieStorage storage, String tablePath,
+ String latestCommitTime, HoodieBaseFile
baseFile, Iterator<T> recordIterator,
+ Schema dataSchema, Schema requestedSchema,
Option<InternalSchema> internalSchemaOpt,
+ HoodieTableMetaClient hoodieTableMetaClient,
TypedProperties props,
+ long start, long length, boolean
shouldUseRecordPosition, boolean allowInflightInstants,
+ boolean emitDelete, boolean sortOutput,
+ List<BaseFileUpdateCallback<T>>
updateCallbacks, boolean enableOptimizedLogBlockScan) {
+ this.readerContext = readerContext;
Review Comment:
can we reuse code for constructors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
