HuangZhenQiu commented on code in PR #13409: URL: https://github.com/apache/hudi/pull/13409#discussion_r2216525215
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/append/AppendWriteFunctionWithBufferSort.java: ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.sink.append; + +import org.apache.flink.table.data.binary.BinaryRowData; +import org.apache.flink.table.planner.codegen.sort.SortCodeGenerator; +import org.apache.flink.table.runtime.generated.GeneratedNormalizedKeyComputer; +import org.apache.flink.table.runtime.generated.GeneratedRecordComparator; +import org.apache.flink.table.runtime.operators.sort.BinaryInMemorySortBuffer; +import org.apache.flink.table.runtime.util.MemorySegmentPool; +import org.apache.hudi.configuration.FlinkOptions; +import org.apache.hudi.sink.StreamWriteOperatorCoordinator; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.util.Collector; +import org.apache.flink.util.FlinkRuntimeException; +import org.apache.hudi.sink.buffer.MemorySegmentPoolFactory; +import org.apache.hudi.sink.bulk.sort.SortOperatorGen; +import org.apache.hudi.sink.utils.BufferUtils; +import org.apache.flink.runtime.operators.sort.QuickSort; +import org.apache.hudi.util.MutableIteratorWrapperIterator; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.stream.Collectors; + +/** + * Sink function to write the data to the underneath filesystem with buffer sort + * to improve the parquet compression rate. + * + * <p>The function writes base files directly for each checkpoint, + * the file may roll over when it’s size hits the configured threshold. + * + * @param <T> Type of the input record + * @see StreamWriteOperatorCoordinator + */ +public class AppendWriteFunctionWithBufferSort<T> extends AppendWriteFunction<T> { + private static final Logger LOG = LoggerFactory.getLogger(AppendWriteFunctionWithBufferSort.class); + private final long writeBufferSize; + private final List<String> sortKeyList; + private final GeneratedNormalizedKeyComputer keyComputer; + private final GeneratedRecordComparator recordComparator; + private transient BinaryInMemorySortBuffer buffer; + private transient MemorySegmentPool memorySegmentPool; + private transient SortOperatorGen sortOperatorGen; + + public AppendWriteFunctionWithBufferSort(Configuration config, RowType rowType) { + super(config, rowType); + this.writeBufferSize = config.get(FlinkOptions.WRITE_BUFFER_SIZE); Review Comment: We do need this internal. Our ingestion platform manages 10k ingestion pipeline for topics with different data volume. It is hard to a customize buffer size for each topic, but it is easier to use number of records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
