yihua commented on code in PR #13528:
URL: https://github.com/apache/hudi/pull/13528#discussion_r2207842178
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java:
##########
@@ -378,9 +374,8 @@ public void testCleanNonPartitionedTable() throws
IOException {
try (SparkRDDWriteClient client = new SparkRDDWriteClient(context,
writeConfig)) {
String instantTime;
for (int idx = 0; idx < 3; ++idx) {
- instantTime = client.createNewInstantTime();
+ instantTime = client.startCommit();
List<HoodieRecord> records = dataGen.generateInserts(instantTime, 1);
- WriteClientTestUtils.startCommitWithTime(client, instantTime);
Review Comment:
Will there be more cleanups on the usage of
`WriteClientTestUtils.startCommitWithTime(client, instantTime)`?
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/action/compact/TestInlineCompaction.java:
##########
@@ -204,12 +205,12 @@ public void testSuccessfulCompactionBasedOnNumOrTime()
throws Exception {
// Given: make three commits
HoodieWriteConfig cfg = getConfigForInlineCompaction(3, 60,
CompactionTriggerStrategy.NUM_OR_TIME);
try (SparkRDDWriteClient<?> writeClient = getHoodieWriteClient(cfg)) {
- List<HoodieRecord> records =
dataGen.generateInserts(writeClient.createNewInstantTime(), 10);
+ List<HoodieRecord> records =
dataGen.generateInserts(WriteClientTestUtils.createNewInstantTime(), 10);
Review Comment:
The instant time can be possibly removed from the APIs of test generator as
the instant time is solely used for constructing String values. Something for
a later refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
