codope commented on code in PR #395:
URL: https://github.com/apache/hudi-rs/pull/395#discussion_r2203215042
##########
crates/core/src/file_group/reader.rs:
##########
@@ -75,8 +75,8 @@ impl FileGroupReader {
/// Creates a new reader with the given base URI and options.
///
/// # Arguments
- /// * `base_uri` - The base URI of the file group's residing table.
- /// * `options` - Additional options for the reader.
+ /// * `base_uri` - The base URI of the file group's residing table.
+ /// * `options` - Additional options for the reader.
Review Comment:
Please ignore these changes while reviewing. When I ran `cargo test
--workspace` there were quite a few doctests that failed locally. So, I had to
fix them.
##########
crates/core/src/timeline/lsm.rs:
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+use crate::config::HudiConfigs;
+use crate::metadata::HUDI_METADATA_DIR;
+use crate::storage::Storage;
+use crate::timeline::instant::Instant;
+use crate::timeline::selector::TimelineSelector;
+use crate::Result;
+use log::debug;
+use std::sync::Arc;
+
+/// LSM timeline for table version 8.
+/// For now, falls back to reading from .hoodie/ directory like active
timeline.
+/// TODO: Add LSM timeline history reading from .hoodie/timeline/ directory
+#[derive(Debug, Clone)]
+pub struct LsmTimeline {
+ storage: Arc<Storage>,
+}
+
+impl LsmTimeline {
+ pub fn new(_hudi_configs: Arc<HudiConfigs>, storage: Arc<Storage>) -> Self
{
+ Self { storage }
+ }
+
+ pub async fn load_instants(
+ &self,
+ selector: &TimelineSelector,
+ desc: bool,
+ ) -> Result<Vec<Instant>> {
+ // For now, fall back to reading from .hoodie/ directory like active
timeline
Review Comment:
Please ignore codecov warnings. We will implement more functionality once
#394 lands. For now, we just fallback to v6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
