Davis-Zhang-Onehouse commented on code in PR #13521:
URL: https://github.com/apache/hudi/pull/13521#discussion_r2201418180
##########
hudi-common/src/main/java/org/apache/hudi/metadata/SecondaryIndexKeyUtils.java:
##########
@@ -53,10 +53,16 @@ public static String
getRecordKeyFromSecondaryIndexKey(String key) {
}
public static String getSecondaryKeyFromSecondaryIndexKey(String key) {
+ // the payload key is in the format of "secondaryKey$primaryKey"
+ // we need to extract the secondary key from the payload key
+ return
unescapeSpecialChars(getUnescapedSecondaryKeyFromSecondaryIndexKey(key));
+ }
+
+ public static String getUnescapedSecondaryKeyFromSecondaryIndexKey(String
key) {
Review Comment:
unescape means value in its literal form, the same value as the column value
in data table, we didn't do any special processing to escape chars. We use
"unescape" and "decoded" interchangeably.
escaped means we escape some chars and in preparation for storing values in
SI. We use "escape" and "encoded" interchangeably.
getSecondaryKeyFromSecondaryIndexKey returns unescaped/decoded key, we
should not name after encoded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
