vinothchandar commented on code in PR #13523:
URL: https://github.com/apache/hudi/pull/13523#discussion_r2192747712
##########
hudi-common/src/main/java/org/apache/hudi/expression/Expression.java:
##########
@@ -40,7 +40,8 @@ enum Operator {
IS_NULL(null, null),
IS_NOT_NULL(null, null),
IN("IN", "IN"),
- NOT("NOT", "NOT");
+ NOT("NOT", "NOT"),
+ SECONDARY_INDEX_KEY_MATCH(null, null);
Review Comment:
this is not a standard expression.. need more thought before adding this.
##########
hudi-common/src/main/java/org/apache/hudi/expression/PartialBindVisitor.java:
##########
@@ -133,6 +133,24 @@ public Expression visitPredicate(Predicate predicate) {
}
}
+ if (predicate instanceof Predicates.SecondaryIndexKeyMatcher) {
Review Comment:
UT?
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroFileReader.java:
##########
@@ -57,6 +57,9 @@ public abstract ClosableIterator<IndexedRecord>
getIndexedRecordsByKeysIterator(
public abstract ClosableIterator<IndexedRecord>
getIndexedRecordsByKeyPrefixIterator(
List<String> sortedKeyPrefixes, Schema readerSchema) throws IOException;
+ public abstract ClosableIterator<IndexedRecord>
getIndexedRecordsBySecondaryIndexKeyMatcherIterator(
Review Comment:
naming..
##########
hudi-common/src/main/java/org/apache/hudi/expression/Predicates.java:
##########
@@ -454,4 +459,78 @@ public List<Expression> getRightChildren() {
return right;
}
}
+
+ public static class SecondaryIndexKeyMatcher implements Predicate {
Review Comment:
UTs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
