the-other-tim-brown commented on code in PR #13444:
URL: https://github.com/apache/hudi/pull/13444#discussion_r2190202688
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupRecordBuffer.java:
##########
@@ -565,27 +570,62 @@ protected boolean hasNextBaseRecord(T baseRecord,
BufferedRecord<T> logRecordInf
Pair<Boolean, T> isDeleteAndRecord = merge(baseRecordInfo,
logRecordInfo);
if (!isDeleteAndRecord.getLeft()) {
// Updates
- nextRecord = readerContext.seal(isDeleteAndRecord.getRight());
+ nextRecord =
readerContext.seal(applyOutputSchemaConversion(isDeleteAndRecord.getRight()));
+ // If the record is not the same as the base record, we can emit an
update
+ if (isDeleteAndRecord.getRight() != baseRecord) {
+ callbackOption.ifPresent(callback -> {
+ BufferedRecord<T> mergeResult =
BufferedRecord.forRecordWithContext(nextRecord,
readerContext.getSchemaHandler().getRequestedSchema(), readerContext,
orderingFieldName, false);
Review Comment:
Yes, it is definitely confusing. I've updated the interface to work off of
avros directly for now since that is what the CDC logger requires. We can
revisit making this interface simply take in the engine record type as well in
the future to avoid these various wrapper objects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
