Davis-Zhang-Onehouse commented on code in PR #13489: URL: https://github.com/apache/hudi/pull/13489#discussion_r2174078971
########## hudi-common/src/main/java/org/apache/hudi/common/function/SerializableFunctionPairIn.java: ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.function; + +import java.io.Serializable; + +@FunctionalInterface Review Comment: Got it. So would you please guide me here? Way we have the naming is because previously we have SerializableFunction which consume something and output a Pair. Then I introduced this function which takes a pair as input an output something. To make the 2 clearly differentiate from each other, I rename the former to be SerializableFunction"PairOut" and the later SerializableFunction"PairIn", I intended to indicate one take it as output and the other take as input. Seem like it confuses you that it returns a boolean. What would you think would be a better naming? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
