danny0405 commented on code in PR #13216:
URL: https://github.com/apache/hudi/pull/13216#discussion_r2167992941
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v2/TimelineArchiverV2.java:
##########
@@ -117,6 +118,11 @@ public int archiveIfRequired(HoodieEngineContext context,
boolean acquireLock) t
deleteArchivedActions(instantsToArchive, context);
// triggers compaction and cleaning only after archiving action
this.timelineWriter.compactAndClean(context);
+ List<HoodieInstant> archivedInstants = instantsToArchive.stream()
Review Comment:
same as above, the logic looks redundant because at here the archiving for
Hoodie already finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
