danny0405 commented on code in PR #13476:
URL: https://github.com/apache/hudi/pull/13476#discussion_r2167943363
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/SecondaryIndexStreamingTracker.java:
##########
@@ -168,29 +169,23 @@ static <T> void trackSecondaryIndexStats(@Nullable
HoodieKey hoodieKey, Option<H
secondaryIndexDefns.forEach(def -> {
String secondaryIndexSourceField = def.getSourceFieldsKey();
Object oldSecondaryKey =
oldRecord.getColumnValueAsJava(writeSchemaWithMetaFields,
secondaryIndexSourceField, config.getProps());
- Object newSecondaryKey = null;
+ Pair<Object, Boolean> oldSecondaryKeyCtx = Pair.of(oldSecondaryKey,
isDelete);
Review Comment:
The `isDelete` seems a constant in this method, why we need a `pair` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
