nsivabalan commented on code in PR #13472:
URL: https://github.com/apache/hudi/pull/13472#discussion_r2160393073
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/WriteHandleMetadataUtils.java:
##########
@@ -129,17 +130,18 @@ static void
trackMetadataIndexStatsForStreamingMetadataWrites(String partitionPa
/**
* Utility function used by HoodieCreateHandle to generate secondary index
stats for the corresponding hoodie record.
*
- * @param record - HoodieRecord
- * @param writeStatus - WriteStatus
+ * @param record - HoodieRecord
+ * @param writeStatus - WriteStatus
* @param writeSchemaWithMetaFields - Schema with metadata fields
- * @param secondaryIndexDefns - Definitions for secondary index which need
to be updated
- * @param hoodieTable - Hoodie table
- * @param taskContextSupplier - Task context supplier
+ * @param secondaryIndexDefns - Definitions for secondary index which
need to be updated
+ * @param hoodieTable - Hoodie table
+ * @param config
+ * @param taskContextSupplier - Task context supplier
+ * @param readerContextFactoryOpt - Option containing reader context
*/
- static void trackMetadataIndexStats(HoodieRecord record, WriteStatus
writeStatus, Schema writeSchemaWithMetaFields, List<Pair<String,
HoodieIndexDefinition>> secondaryIndexDefns,
- HoodieTable hoodieTable,
TaskContextSupplier taskContextSupplier) {
- HoodieEngineContext engineContext = new
HoodieLocalEngineContext(hoodieTable.getStorageConf(), taskContextSupplier);
- HoodieReaderContext readerContext =
engineContext.getReaderContextFactory(hoodieTable.getMetaClient()).getContext();
+ static <T> void trackMetadataIndexStats(HoodieRecord record, WriteStatus
writeStatus, Schema writeSchemaWithMetaFields, List<Pair<String,
HoodieIndexDefinition>> secondaryIndexDefns,
+ HoodieTable hoodieTable,
HoodieWriteConfig config, TaskContextSupplier taskContextSupplier,
Option<ReaderContextFactory<T>> readerContextFactoryOpt) {
+ HoodieReaderContext readerContext =
readerContextFactoryOpt.get().getContext();
Review Comment:
similarly, where ever we are doing `instanceof HoodieAvroIndexedRecord` need
to be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
