vinishjail97 opened a new pull request, #13453:
URL: https://github.com/apache/hudi/pull/13453
### Change Logs
There's a gap in the completionTime generation code. We don't use
currentTimeMillis coming from the skew adjusting time generator and generate a
new time. There's no issue in correctness but yeah we are generating a new
timestamp without a need for it and can be avoided.
```
timeGenerator.consumeTime(!shouldLock, currentTimeMillis -> {
String completionTime = TimelineUtils.generateInstantTime(false,
timeGenerator);
String fileName = instantFileNameGenerator.getFileName(completionTime,
instant);
```
### Impact
Avoid generating timestamp twice in createCompleteFileInMetaPath.
### Risk level (write none, low medium or high below)
Medium
### Documentation Update
None.
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
