nsivabalan commented on code in PR #13402:
URL: https://github.com/apache/hudi/pull/13402#discussion_r2148863536


##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/functional/TestHoodieClientOnCopyOnWriteStorage.java:
##########
@@ -1037,7 +1037,6 @@ public void 
testRollbackOfRegularCommitWithPendingReplaceCommitInTimeline() thro
     // trigger another commit. this should rollback latest partial commit.
     JavaRDD<WriteStatus> statuses = (JavaRDD<WriteStatus>)
         insertBatchRecords(client, commitTime1, 200, 1, 2, 
SparkRDDWriteClient::upsert).getLeft();
-    client.commit(commitTime1, statuses);

Review Comment:
   insertBatchRecords already calls commit. so, this is a repeated call to 
commit. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to