vinothchandar commented on code in PR #13399:
URL: https://github.com/apache/hudi/pull/13399#discussion_r2136600316
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/DirectWriteMarkers.java:
##########
@@ -189,26 +188,17 @@ public Option<StoragePath>
createWithEarlyConflictDetection(String partitionPath
private Option<StoragePath> create(StoragePath markerPath, boolean
checkIfExists) {
HoodieTimer timer = HoodieTimer.start();
- StoragePath dirPath = markerPath.getParent();
- try {
- if (!storage.exists(dirPath)) {
- storage.createDirectory(dirPath); // create a new partition as needed.
Review Comment:
To be on the same page...
Are you referring to the ` storage.create(markerPath, false).close();` call
below creating the partition structure, also, if the markerPath does not exist?
I am kind of surprised that Hadoop FileSystem fs.create(), which is what
storage.create() will delegate to, does that. Are we sure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
