danny0405 commented on code in PR #13300:
URL: https://github.com/apache/hudi/pull/13300#discussion_r2114918185
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -686,4 +597,26 @@ record -> {
.stream()
.collect(Collectors.groupingBy(Pair::getKey,
Collectors.mapping(Pair::getValue, Collectors.toSet())));
}
+
+ /**
+ * Derive necessary properties for FG reader.
+ */
+ TypedProperties buildFileGroupReaderProperties(HoodieMetadataConfig
metadataConfig) {
+ HoodieCommonConfig commonConfig = HoodieCommonConfig.newBuilder()
+ .fromProperties(metadataConfig.getProps()).build();
+ TypedProperties props = TypedProperties.copy(metadataConfig.getProps());
Review Comment:
the `metadataConfig.getProps()` include all the write config options, it's
more safe we just set up the options required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
