nsivabalan commented on code in PR #13295:
URL: https://github.com/apache/hudi/pull/13295#discussion_r2112784913
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1408,6 +1411,8 @@ protected void commitInternal(String instantTime,
Map<String, HoodieData<HoodieR
bulkInsertAndCommit(writeClient, instantTime, preppedRecordInputs,
bulkInsertPartitioner);
} else {
engineContext.setJobStatus(this.getClass().getSimpleName(),
String.format("Upserting at %s into metadata table %s", instantTime,
metadataWriteConfig.getTableName()));
+ // to do: fix the last argument is required so that we can support
streaming writes to metadata table.
+ // Option.of(partitionFileIdPairs)
Review Comment:
actually, I have fixed this.
anyways, I did not fix the writeclient instantiation in
SparkHoodieBackedTableMetadataWriter. So, this will not be used in prod yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
