danny0405 commented on PR #13355:
URL: https://github.com/apache/hudi/pull/13355#issuecomment-2908471971

   Please also check all the `writeClient.deletePartitions` to ensure there is 
no function regression.
   
   Should we add auto commit to the spark 
`HoodieSparkCopyOnWriteTable.deletePartitions`, I see many places missed to 
commit the write status.
   
   - `DataSourceUtils.doDeletePartitionsOperation`
   - `SparkHoodieBackedTableMetadataWriterTableVersionSix#deletePartitions`
   - `org.apache.hudi.examples.spark.HoodieWriteClientExample`
   - `StreamSync`
   
   I checked the `managePartitionTTL`, the auto commit was there, why the auto 
commit is missing for `deletePartitions`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to