TheR1sing3un commented on code in PR #13351:
URL: https://github.com/apache/hudi/pull/13351#discussion_r2106060707


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -172,7 +172,11 @@ case class HoodieFileIndex(spark: SparkSession,
    * @return list of PartitionDirectory containing partition to base files 
mapping
    */
   override def listFiles(partitionFilters: Seq[Expression], dataFilters: 
Seq[Expression]): Seq[PartitionDirectory] = {
-    val prunedPartitionsAndFilteredFileSlices = filterFileSlices(dataFilters, 
partitionFilters).map {
+    val prunedPartitionsAndFilteredFileSlices = filterFileSlices(dataFilters, 
partitionFilters).flatMap(
+      { case (partitionOpt, fileSlices) =>

Review Comment:
   > so now one `PartitionDirectory` only contains one file slice? makes sense 
in general I think.
   
   Yes, when this `PartitionDirectory` is used on the spark side, it only 
shares the same `PartitionValue` for the `FileStatus` under 
`PartitionDirectory`. Other than that, it seems to have no other usage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to