Copilot commented on code in PR #13226:
URL: https://github.com/apache/hudi/pull/13226#discussion_r2103542283
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriterTableVersionSix.java:
##########
@@ -72,10 +80,14 @@ protected
HoodieBackedTableMetadataWriterTableVersionSix(StorageConfiguration<?>
HoodieWriteConfig
writeConfig,
HoodieFailedWritesCleaningPolicy failedWritesCleaningPolicy,
HoodieEngineContext
engineContext,
+
Option<Set<MetadataPartitionType>> partitionTypesOpt,
+
ExpressionIndexRecordGenerator indexHelper,
Option<String>
inflightInstantTimestamp) {
- super(storageConf, writeConfig, failedWritesCleaningPolicy, engineContext,
inflightInstantTimestamp);
+ super(storageConf, writeConfig, failedWritesCleaningPolicy, engineContext,
partitionTypesOpt, indexHelper, inflightInstantTimestamp);
}
+ // TODO(yihua): move this filtering
+ /*
Review Comment:
[nitpick] There is a large commented-out block of code for
`getEnabledPartitions`. Remove this dead code or move it to a proper feature
branch to keep the codebase clean.
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/metadata/JavaHoodieBackedTableMetadataWriter.java:
##########
@@ -57,8 +54,13 @@ public class JavaHoodieBackedTableMetadataWriter extends
HoodieBackedTableMetada
*/
protected JavaHoodieBackedTableMetadataWriter(StorageConfiguration<?>
storageConf, HoodieWriteConfig writeConfig, HoodieFailedWritesCleaningPolicy
failedWritesCleaningPolicy,
HoodieEngineContext
engineContext,
+
Option<Set<MetadataPartitionType>> partitionTypesOpt,
Option<String>
inflightInstantTimestamp) {
- super(storageConf, writeConfig, failedWritesCleaningPolicy, engineContext,
inflightInstantTimestamp);
+ super(storageConf, writeConfig, failedWritesCleaningPolicy, engineContext,
+ partitionTypesOpt,
+ // TODO(yihua): fix
+ null,
Review Comment:
Passing null as the index record generator may lead to NPEs when the writer
tries to generate index records. Consider injecting a default
`ExpressionIndexRecordGenerator` (or appropriate index helper) instead of null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
