nsivabalan commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2103342067


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -64,6 +64,8 @@ public interface HoodieActiveTimeline extends HoodieTimeline {
 
   HoodieInstant createRequestedCommitWithReplaceMetadata(String instantTime, 
String actionType);
 
+  String createCompletionTime();

Review Comment:
   yes, HoodieActiveTimeline is an interface and we don't have access to meta 
client object. 
   I generally see lot of code duplications across V1 and V2 and did not want 
to dislodge that as part of this patch. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to