lokeshj1703 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2085323075
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieIndexer.java:
##########
@@ -496,9 +493,7 @@ private void upsertToTable(HoodieMetadataConfig
metadataConfig, String tableName
String instant = writeClient.createNewInstantTime();
writeClient.startCommitWithTime(instant);
List<HoodieRecord> records = DATA_GENERATOR.generateInserts(instant,
100);
- JavaRDD<WriteStatus> result =
writeClient.upsert(jsc().parallelize(records, 1), instant);
- List<WriteStatus> statuses = result.collect();
- assertNoWriteErrors(statuses);
Review Comment:
Addressed
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestHoodieIncrSource.java:
##########
@@ -764,8 +772,7 @@ private WriteResult writeRecords(SparkRDDWriteClient
writeClient,
JavaRDD<WriteStatus> result = writeOperationType ==
WriteOperationType.BULK_INSERT
? writeClient.bulkInsert(jsc().parallelize(records, 1), commit)
: writeClient.upsert(jsc().parallelize(records, 1), commit);
- List<WriteStatus> statuses = result.collect();
- assertNoWriteErrors(statuses);
Review Comment:
Addressed
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestHoodieIncrSource.java:
##########
@@ -367,15 +371,17 @@ public void
testHoodieIncrSourceInflightCommitBeforeCompletedCommit(HoodieTableT
@ParameterizedTest
@EnumSource(HoodieTableType.class)
- public void testHoodieIncrSourceWithPendingTableServices(HoodieTableType
tableType) throws IOException {
+ public void testHoodieIncrSourceWithPendingTableServices() throws
IOException {
+ HoodieTableType tableType = MERGE_ON_READ;
this.tableType = tableType;
- metaClient = getHoodieMetaClient(storageConf(), basePath());
+ fs().delete(new Path(basePath()));
Review Comment:
Addressed
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestGcsEventsHoodieIncrSource.java:
##########
@@ -442,10 +443,7 @@ private Pair<String, List<HoodieRecord>>
writeGcsMetadataRecords(String commitTi
getGcsMetadataRecord(commitTime, "data-file-4.json", "bucket-1", "1")
);
JavaRDD<WriteStatus> result =
writeClient.upsert(jsc().parallelize(gcsMetadataRecords, 1), commitTime);
-
- List<WriteStatus> statuses = result.collect();
- assertNoWriteErrors(statuses);
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
