danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2079532088
##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/client/TestJavaHoodieBackedMetadata.java:
##########
@@ -1668,7 +1668,7 @@ private void testTableOperationsImpl(HoodieEngineContext
engineContext, HoodieWr
client.scheduleCompactionAtInstant(newCommitTime, Option.empty());
HoodieWriteMetadata writeMetadata = client.compact(newCommitTime);
client.commitCompaction(newCommitTime, writeMetadata, Option.empty());
- metaClient.reloadActiveTimeline().containsInstant(newCommitTime);
+
metaClient.reloadActiveTimeline().filterCompletedInstants().containsInstant(newCommitTime);
Review Comment:
what is the function of the `#contains` invocation?
```java
client.commitCompaction(newInstant, result, HOption.empty())
metaClient.reloadActiveTimeline.containsInstant(newInstant)
```
there is no any assertion and does the compaction already committed there?
If we wanna completion check here, just check the existence of the completed
instant file on the file system instead of loading/listing the whole timeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
