nsivabalan commented on code in PR #13015:
URL: https://github.com/apache/hudi/pull/13015#discussion_r2076103375
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java:
##########
@@ -120,6 +121,11 @@ public static HoodieWriteConfig createMetadataWriteConfig(
.withMaxConsistencyChecks(writeConfig.getConsistencyGuardConfig().getMaxConsistencyChecks())
.build())
.withWriteConcurrencyMode(WriteConcurrencyMode.SINGLE_WRITER)
+ .withFileSystemViewConfig(FileSystemViewStorageConfig.newBuilder()
+
.withStorageType(writeConfig.getMetadataConfig().getMetadataViewType())
+
.withBaseStoreDir(writeConfig.getViewStorageConfig().getSpillableDir())
Review Comment:
should we suffix "/metadata" to
writeConfig.getViewStorageConfig().getSpillableDir()
so that we de-couple data table and metadata table spillable dir.
or you intentionally wanted to keep it to just 1 dir for a given table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
