danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2074779202
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java:
##########
@@ -270,6 +270,7 @@ private int doCompact(JavaSparkContext jsc) throws
Exception {
}
}
HoodieWriteMetadata<JavaRDD<WriteStatus>> compactionMetadata =
client.compact(cfg.compactionInstantTime);
+ client.commitCompaction(cfg.compactionInstantTime, compactionMetadata,
Option.empty());
Review Comment:
I'm not sure if the `commitXXX` plus `completeXXX` combination as public API
makes sense in general, because from intuition, the `commitXXX` already means
to complete the commit. Inversely I kind of think the `completeXXX` should be
deemed as a internal API to support tests/debugging or some cases that needs
flexibility.
I know Spark has issues/feature like lazy triggering of computation of RDDs,
but let's make our API semantics clear first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
