yihua commented on code in PR #12983: URL: https://github.com/apache/hudi/pull/12983#discussion_r2061003251
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/index/EngineIndexHelper.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.metadata.index; + +import org.apache.hudi.common.data.HoodieData; +import org.apache.hudi.common.engine.EngineType; +import org.apache.hudi.common.model.HoodieIndexDefinition; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.util.collection.Pair; +import org.apache.hudi.storage.StorageConfiguration; + +import org.apache.avro.Schema; + +import java.util.List; + +public interface EngineIndexHelper { + EngineType getEngineType(); + + /** + * Generates expression index records + * + * @param partitionFilePathAndSizeTriplet Triplet of file path, file size and partition name to which file belongs + * @param indexDefinition Hoodie Index Definition for the expression index for which records need to be generated + * @param metaClient Hoodie Table Meta Client + * @param parallelism Parallelism to use for engine operations + * @param readerSchema Schema of reader + * @param storageConf Storage Config + * @param instantTime Instant time + * @return HoodieData wrapper of expression index HoodieRecords + */ + HoodieData<HoodieRecord> getExpressionIndexRecords( + List<Pair<String, Pair<String, Long>>> partitionFilePathAndSizeTriplet, Review Comment: Yes, added `FileToIndex` to wrap the information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
