yihua commented on code in PR #13208:
URL: https://github.com/apache/hudi/pull/13208#discussion_r2059331882
##########
hudi-common/src/main/java/org/apache/hudi/keygen/KeyGenerator.java:
##########
@@ -56,4 +62,36 @@ public List<String> getRecordKeyFieldNames() {
throw new UnsupportedOperationException("Bootstrap not supported for key
generator. "
+ "Please override this method in your custom key generator.");
}
+
+ public static String constructRecordKey(String[] recordKeyFields,
Function<String, Object> recordKeyValueFunction) {
Review Comment:
nit: should the result of the function be in `String` type so there is no
confusion on `object.toString()` in case the `recordKeyValue` is not a `String`
object (i.e., let the engine to make sure the value is properly converted, say
for byte buffer)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
