yihua commented on code in PR #13208:
URL: https://github.com/apache/hudi/pull/13208#discussion_r2059164091
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -168,32 +166,8 @@ public String getPartitionPath(RowData rowData) {
}
}
- // reference: org.apache.hudi.keygen.KeyGenUtils.getRecordKey
private static String getRecordKey(Object[] keyValues, String[] keyFields,
boolean consistentLogicalTimestampEnabled) {
- boolean keyIsNullEmpty = true;
- StringBuilder recordKey = new StringBuilder();
- for (int i = 0; i < keyValues.length; i++) {
- String recordKeyField = keyFields[i];
- Object value = keyValues[i];
- value = getTimestampValue(consistentLogicalTimestampEnabled, value);
- String recordKeyValue = StringUtils.objToString(value);
Review Comment:
If value is an instance of `ByteBuffer`, there's a behavior change from this
PR (on master branch, this is different from `KeyGenUtils#getRecordKey`).
@danny0405 do you know if this is a legit use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
