cshuo commented on code in PR #13213:
URL: https://github.com/apache/hudi/pull/13213#discussion_r2057064037
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -285,6 +277,14 @@ public abstract HoodieRecord<T>
constructHoodieRecord(Option<T> recordOption,
*/
public abstract T seal(T record);
+ /**
+ * Convert engine specific row into binary format.
+ *
+ * @param record The engine row
+ * @return row with binary format
+ */
+ public abstract T toBinaryRow(T record);
Review Comment:
We should only enforce the row that would be put in spillable map has binary
format. And `seal` is called in multiple places, e.g., `baseRecord` read from
base file is also sealed, where `toBinary` is not necessary to avoid additional
costs. That's the context we introduce a new method `toBinary` to separate
`seal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
