linliu-code commented on code in PR #13213:
URL: https://github.com/apache/hudi/pull/13213#discussion_r2056716215
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -243,39 +244,30 @@ public String getRecordKey(T record, Schema schema) {
/**
* Gets the ordering value in particular type.
*
- * @param recordOption An option of record.
- * @param metadataMap A map containing the record metadata.
- * @param schema The Avro schema of the record.
+ * @param record An option of record.
+ * @param schema The Avro schema of the record.
* @param orderingFieldName name of the ordering field
* @return The ordering value.
*/
- public Comparable getOrderingValue(Option<T> recordOption,
- Map<String, Object> metadataMap,
+ public Comparable getOrderingValue(T record,
Schema schema,
Option<String> orderingFieldName) {
- if (metadataMap.containsKey(INTERNAL_META_ORDERING_FIELD)) {
Review Comment:
Should we also remove the L149 ~ L154?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
