the-other-tim-brown commented on code in PR #13208:
URL: https://github.com/apache/hudi/pull/13208#discussion_r2055149040
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/TestHoodieFileGroupReaderBase.java:
##########
@@ -154,10 +154,17 @@ public void
testReadFileGroupInMergeOnReadTable(RecordMergeMode recordMergeMode,
}
}
+ private static Stream<Arguments> logFileOnlyCases() {
+ return Stream.of(
+ arguments(RecordMergeMode.COMMIT_TIME_ORDERING, "avro"),
+ arguments(RecordMergeMode.EVENT_TIME_ORDERING, "parquet"),
+ arguments(RecordMergeMode.CUSTOM, "avro"));
+ }
+
@ParameterizedTest
- @MethodSource("testArguments")
- public void testReadLogFilesOnlyInMergeOnReadTable(RecordMergeMode
recordMergeMode, String logDataBlockFormat, boolean populateMetaFields) throws
Exception {
- Map<String, String> writeConfigs = new
HashMap<>(getCommonConfigs(recordMergeMode, populateMetaFields));
+ @MethodSource("logFileOnlyCases")
+ public void testReadLogFilesOnlyInMergeOnReadTable(RecordMergeMode
recordMergeMode, String logDataBlockFormat) throws Exception {
Review Comment:
If the meta fields are not populated, the in-memory index does not work so I
had to add a different set of cases here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
