TheR1sing3un commented on code in PR #13107:
URL: https://github.com/apache/hudi/pull/13107#discussion_r2036787828
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedParquetFileFormat.scala:
##########
@@ -167,6 +175,7 @@ class
HoodieFileGroupReaderBasedParquetFileFormat(tablePath: String,
.builder().setConf(storageConf).setBasePath(tablePath).build
val props = metaClient.getTableConfig.getProps
options.foreach(kv => props.setProperty(kv._1, kv._2))
+ props.put(HoodieMemoryConfig.MAX_MEMORY_FOR_MERGE.key(),
String.valueOf(maxMemoryPerCompaction))
Review Comment:
> Can you elaborate how the file group reader utilizes this option?
The `FileGroupRecordBuffer` will create a `ExternalSpillableMap` with
`maxInMemorySizeInBytes` to cache the `log records` in memory.
<img width="1083" alt="image"
src="https://github.com/user-attachments/assets/f8e249b8-8d6e-4e03-8e9a-c92f4a22616c";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
