liujinhui1994 commented on a change in pull request #2122:
URL: https://github.com/apache/hudi/pull/2122#discussion_r512697102
##########
File path:
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/PartitionValueExtractorTest.java
##########
@@ -0,0 +1,17 @@
+package org.apache.hudi.hive;
+
+import org.junit.jupiter.api.Test;
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class PartitionValueExtractorTest {
+ @Test
+ public void testHourPartition() {
Review comment:
ok
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SlashEncodedHourPartitionValueExtractor.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hive;
+
+import org.joda.time.DateTime;
+import org.joda.time.format.DateTimeFormat;
+import org.joda.time.format.DateTimeFormatter;
+
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * HDFS Path contain hive partition values for the keys it is partitioned on.
This mapping is not straight forward and
+ * requires a pluggable implementation to extract the partition value from
HDFS path.
+ * <p>
+ * This implementation extracts datestr=yyyy-mm-dd-HH from path of type
/yyyy/mm/dd/HH
+ */
+public class SlashEncodedHourPartitionValueExtractor implements
PartitionValueExtractor {
+
+ private static final long serialVersionUID = 1L;
+ private transient DateTimeFormatter dtfOut;
+
+ public SlashEncodedHourPartitionValueExtractor() {
+ this.dtfOut = DateTimeFormat.forPattern("yyyy-MM-dd-HH");
+ }
+
+ private DateTimeFormatter getDtfOut() {
+ if (dtfOut == null) {
+ dtfOut = DateTimeFormat.forPattern("yyyy-MM-dd-HH");
+ }
+ return dtfOut;
+ }
+
+ @Override
+ public List<String> extractPartitionValuesInPath(String partitionPath) {
+ // partition path is expected to be in this format yyyy/mm/dd/HH
+ String[] splits = partitionPath.split("/");
+ if (splits.length != 4) {
+ throw new IllegalArgumentException("Partition path " + partitionPath + "
is not in the form yyyy/mm/dd/HH");
+ }
+ // Get the partition part and remove the / as well at the end
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
