wangyinsheng commented on code in PR #13068:
URL: https://github.com/apache/hudi/pull/13068#discussion_r2024650910
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -207,25 +208,25 @@ public boolean commit(String instantTime, O
writeStatuses, Option<Map<String, St
public boolean commit(String instantTime, O writeStatuses,
Option<Map<String, String>> extraMetadata,
String commitActionType, Map<String, List<String>>
partitionToReplacedFileIds) {
return commit(instantTime, writeStatuses, extraMetadata, commitActionType,
partitionToReplacedFileIds,
- Option.empty());
+ Option.empty()).isSuccess();
}
- public abstract boolean commit(String instantTime, O writeStatuses,
Option<Map<String, String>> extraMetadata,
+ public abstract CommitStatus commit(String instantTime, O writeStatuses,
Option<Map<String, String>> extraMetadata,
Review Comment:
> For this case, we can return null?
Many callers need to verify success or failure， return null for
`EmptyCommit` case and return option for other cases will change simple
boolean check to `commitMetadataOpt == null || commitMetadataOpt.ifPresent`,
This is a bit weird，I Idon't think it is a good way。
https://github.com/apache/hudi/blob/93b4da301d12b4a2d66787d80ce3071876aaad22/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java#L588-L594
https://github.com/apache/hudi/blob/93b4da301d12b4a2d66787d80ce3071876aaad22/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala#L1002-L1011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
