yihua commented on code in PR #13010:
URL: https://github.com/apache/hudi/pull/13010#discussion_r2020036550
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -82,20 +82,17 @@ public final class HoodieFileGroupReader<T> implements
Closeable {
private ClosableIterator<T> baseFileIterator;
private final Option<UnaryOperator<T>> outputConverter;
private final HoodieReadStats readStats;
+ // Allows to consider inflight instants while merging log records using
HoodieMergedLogRecordReader
+ // The inflight instants need to be considered while updating RLI records.
RLI needs to fetch the revived
+ // and deleted keys from the log files written as part of active data
commit. During the RLI update,
+ // the allowInflightInstants flag would need to be set to true. This would
ensure the HoodieMergedLogRecordReader
Review Comment:
I'm OK with this flag temporarily, but as @danny0405 mentioned we should
really get rid of such unorthodox read logic that is only due to bandaid, after
rewriting of MDT write path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
