lokeshj1703 commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2018358599
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1089,35 +1089,6 @@ public static Set<String> getRecordKeys(List<String>
logFilePaths, HoodieTableMe
return Collections.emptySet();
}
- private static void reAddLogFilesFromRollbackPlan(HoodieTableMetaClient
dataTableMetaClient, String instantTime,
- Map<String, Map<String,
Long>> partitionToFilesMap) {
- InstantGenerator factory = dataTableMetaClient.getInstantGenerator();
Review Comment:
The logic was removed in HUDI-1517. Based on discussion with @codope,
rollback in data table was changed from deltacommit in MDT to rollback in MDT
after release 0.14. This change was therefore not required.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/marker/MarkerOperation.java:
##########
@@ -34,6 +34,7 @@ public class MarkerOperation implements Serializable {
// GET requests
public static final String ALL_MARKERS_URL = String.format("%s/%s",
BASE_URL, "all");
public static final String CREATE_AND_MERGE_MARKERS_URL =
String.format("%s/%s", BASE_URL, "create-and-merge");
+ public static final String APPEND_MARKERS_URL = String.format("%s/%s",
BASE_URL, "append");
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
