the-other-tim-brown commented on code in PR #13039:
URL: https://github.com/apache/hudi/pull/13039#discussion_r2015309942
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/BaseZookeeperBasedLockProvider.java:
##########
@@ -69,12 +69,13 @@ public BaseZookeeperBasedLockProvider(final
LockConfiguration lockConfiguration,
zkBasePath = getZkBasePath(lockConfiguration);
lockKey = getLockKey(lockConfiguration);
this.curatorFrameworkClient = CuratorFrameworkFactory.builder()
-
.connectString(lockConfiguration.getConfig().getString(ZK_CONNECT_URL_PROP_KEY))
- .retryPolicy(new
BoundedExponentialBackoffRetry(lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_RETRY_WAIT_TIME_IN_MILLIS_PROP_KEY),
-
lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_RETRY_MAX_WAIT_TIME_IN_MILLIS_PROP_KEY),
-
lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_NUM_RETRIES_PROP_KEY)))
-
.sessionTimeoutMs(lockConfiguration.getConfig().getInteger(ZK_SESSION_TIMEOUT_MS_PROP_KEY,
DEFAULT_ZK_SESSION_TIMEOUT_MS))
-
.connectionTimeoutMs(lockConfiguration.getConfig().getInteger(ZK_CONNECTION_TIMEOUT_MS_PROP_KEY,
DEFAULT_ZK_CONNECTION_TIMEOUT_MS))
+
.connectString(ConfigUtils.getStringWithAltKeys(lockConfiguration.getConfig(),
ZK_CONNECT_URL))
+ .retryPolicy(new BoundedExponentialBackoffRetry(
+ ConfigUtils.getIntWithAltKeys(lockConfiguration.getConfig(),
LOCK_ACQUIRE_RETRY_WAIT_TIME_IN_MILLIS),
Review Comment:
Yes, the ConfigProperty references the previous string constants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
