yihua commented on code in PR #13010:
URL: https://github.com/apache/hudi/pull/13010#discussion_r2014680390
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java:
##########
@@ -136,16 +136,14 @@ public abstract class BaseHoodieLogRecordReader<T> {
// Use scanV2 method.
private final boolean enableOptimizedLogBlocksScan;
protected HoodieFileGroupRecordBuffer<T> recordBuffer;
+ // Allows to consider inflight instants while merging log records
+ protected boolean allowInflightInstants;
- protected BaseHoodieLogRecordReader(HoodieReaderContext readerContext,
- HoodieStorage storage,
- List<String> logFilePaths,
+ protected BaseHoodieLogRecordReader(HoodieReaderContext readerContext,
HoodieStorage storage, List<String> logFilePaths,
boolean reverseReader, int bufferSize,
Option<InstantRange> instantRange,
- boolean withOperationField, boolean
forceFullScan,
- Option<String> partitionNameOverride,
- Option<String> keyFieldOverride,
- boolean enableOptimizedLogBlocksScan,
- HoodieFileGroupRecordBuffer<T>
recordBuffer) {
+ boolean withOperationField, boolean
forceFullScan, Option<String> partitionNameOverride,
+ Option<String> keyFieldOverride, boolean
enableOptimizedLogBlocksScan, HoodieFileGroupRecordBuffer<T> recordBuffer,
+ boolean allowInflightInstants) {
Review Comment:
Could you add javadocs on why `allowInflightInstants` is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
