sgomezvillamor commented on code in PR #13018: URL: https://github.com/apache/hudi/pull/13018#discussion_r2012226165
########## hudi-sync/hudi-datahub-sync/src/test/java/org/apache/hudi/sync/datahub/TestDataHubTableProperties.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.sync.datahub; + +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.model.HoodieTableType; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.table.HoodieTableVersion; +import org.apache.hudi.hadoop.HoodieParquetInputFormat; +import org.apache.hudi.sync.datahub.config.DataHubSyncConfig; + +import org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat; +import org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe; +import org.apache.parquet.schema.MessageType; +import org.apache.parquet.schema.PrimitiveType; +import org.apache.parquet.schema.Type; +import org.junit.jupiter.api.Test; + +import java.util.HashMap; +import java.util.Map; + +import static org.apache.hudi.sync.common.HoodieSyncConfig.META_SYNC_BASE_PATH; +import static org.apache.hudi.sync.datahub.DataHubTableProperties.HUDI_BASE_PATH; +import static org.apache.hudi.sync.datahub.DataHubTableProperties.HUDI_TABLE_TYPE; +import static org.apache.hudi.sync.datahub.DataHubTableProperties.HUDI_TABLE_VERSION; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.mockito.Mockito.RETURNS_DEEP_STUBS; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +class TestDataHubTableProperties { + @Test + void testGetTableProperties() { + String path = "file:///tmp/path"; + Map<String, String> expected = new HashMap<>(); + expected.put(HUDI_TABLE_TYPE, "MERGE_ON_READ"); + expected.put(HUDI_TABLE_VERSION, "SIX"); Review Comment: What I mean is in any case this is responsibility of the datahub-sync controller. About this being a number in the `hoodie.properties`, that matches the code here https://github.com/apache/hudi/blob/9352576357da04080a15456a01d6993cd553dec2/hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java#L703-L707 So, there is some misalignment in Hudi and apparently this is loaded from version code and reported as string enum representation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
