nsivabalan commented on code in PR #13009:
URL: https://github.com/apache/hudi/pull/13009#discussion_r2010437497
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/SevenToEightUpgradeHandler.java:
##########
@@ -178,19 +178,28 @@ static void upgradePartitionFields(HoodieWriteConfig
config, HoodieTableConfig t
}
static void upgradeMergeMode(HoodieTableConfig tableConfig,
Map<ConfigProperty, String> tablePropsToAdd) {
- if (tableConfig.getPayloadClass() != null
- &&
tableConfig.getPayloadClass().equals(OverwriteWithLatestAvroPayload.class.getName()))
{
- if (HoodieTableType.COPY_ON_WRITE == tableConfig.getTableType()) {
+ if (tableConfig.getPayloadClass() != null) {
+ if
(tableConfig.getPayloadClass().equals(OverwriteWithLatestAvroPayload.class.getName()))
{
+ if (HoodieTableType.COPY_ON_WRITE == tableConfig.getTableType()) {
Review Comment:
lets first align on all diff combinations and whats expected behavior during
upgrade and downgrade before going ahead w/ the patch. we can sync up f2f on
this
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/SevenToEightUpgradeHandler.java:
##########
@@ -178,19 +178,28 @@ static void upgradePartitionFields(HoodieWriteConfig
config, HoodieTableConfig t
}
static void upgradeMergeMode(HoodieTableConfig tableConfig,
Map<ConfigProperty, String> tablePropsToAdd) {
- if (tableConfig.getPayloadClass() != null
- &&
tableConfig.getPayloadClass().equals(OverwriteWithLatestAvroPayload.class.getName()))
{
- if (HoodieTableType.COPY_ON_WRITE == tableConfig.getTableType()) {
+ if (tableConfig.getPayloadClass() != null) {
Review Comment:
yes. I am also thinking if we really need a functional test?
why can't we add tests directly against upgrade handler. validate the table
config props before and after upgrade and be done with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
